Skip to content

Presentation completion handler, safer completion blocks, light 'secure logos' to be visible in dark mode #52

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

illabo
Copy link
Contributor

@illabo illabo commented Jun 21, 2020

  • Now it is possible to add presentation completion through setting in ASDKPaymentFormStarter's designConfiguration new method - (void)setPresentationCompletion:(void (^)(void))presentationCompletion. Also added an option to turn off animations on presentation with - (void)setPresentAnimated:(BOOL)animated.

Use case: I want to have loading animation shown up until the moment of ASDKPaymentFormViewController fully presented.

  • Calls to onSuccess, onError, onCancelled made safer. Now you may pass nil instead of a handler and get away without crashing the app.

Use case: Sometimes you just don't want to do anything on cancellation. Why to pass empty block when it is expected to pass nil? Others are also checked just in case.

  • Some logos was barely visible in dark mode if at all (e.g. Tinkoff logo and Visa logo). Separate image with lightened logos is added to assets to be shown in dark mode.

Why: For better appearance.

@illabo illabo changed the title Presentation completion handler Presentation completion handler, safer completion blocks, light 'secure logos' to be visible in dark mode Jun 22, 2020
@illabo illabo force-pushed the master branch 3 times, most recently from e148e2e to 08c7c68 Compare June 22, 2020 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant